issues with the recent ath commits (r227740, r227651, ...)

Alexander Best arundel at freebsd.org
Mon Nov 21 22:02:12 UTC 2011


On Tue Nov 22 11, Adrian Chadd wrote:
> Hi,
> 
> Please try this patch:

thanks for the patch. i'll try it out right away.

> 
> 
> commit 3993972ed7407867dce188903f68a0751c487fbb
> Author: Adrian Chadd <adrian at freebsd.org>
> Date:   Tue Nov 22 05:28:16 2011 +0800
> 
>     Sleep on the correct lock.
> 
> diff --git a/sys/dev/ath/if_ath.c b/sys/dev/ath/if_ath.c
> index 83c5ede..84cb91b 100644
> --- a/sys/dev/ath/if_ath.c
> +++ b/sys/dev/ath/if_ath.c
> @@ -1878,9 +1878,9 @@ ath_txrx_stop(struct ath_softc *sc)
>          */
>         while (sc->sc_rxproc_cnt || sc->sc_txproc_cnt ||
>             sc->sc_txstart_cnt || sc->sc_intr_cnt) {
> -               if (i <= 0)
> +               if (i <= 0)

what does this change do? ;)

>                         break;
> -               msleep(sc, &sc->sc_mtx, 0, "ath_txrx_stop", 1);
> +               msleep(sc, &sc->sc_pcu_mtx, 0, "ath_txrx_stop", 1);
>                 i--;
>         }
>         ATH_PCU_UNLOCK(sc);

cheers.
alex


More information about the freebsd-wireless mailing list