Do you respect the date_modified field?

[Dan Langille]

On 17 Dec 2004 at 19:50, Simon L. Nielsen wrote:

> On 2004.12.17 12:37:35 -0500, Dan Langille wrote:
> > At present, FreshPorts deletes all VuXML information each time a 
> > commit to ~/ports/security/vuxml/vuln.xml occurs.  To reduce database 
> > churn, I'm now looking at optimizing this process.
> > 
> > I expect the answer to my question to be yes, but do not want to rely 
> > upon only my expectation.  Do you respect the date_modified field?
> 
> In general yes, though of course there can be slips sometimes.  Of
> course, if FreshPorts starts to use the modified date I think it's
> even more likely that modified date will be updated correctly since
> people will notice if it wasn't bumped.
> 
> I almost always check my entries on FreshPorts after commit as an
> extra check that I havn't made any mistakes in the committed entry...
> 
> > I ask for reasons of keeping things simple.  FreshPorts inserts each 
> > vuln into a table.  Is it sufficient for FreshPorts to compare the 
> > last_modified field as supplied in vuln.xml to determine whether or 
> > not it should update its information?
> 
> Not quite that simple unfortunatly.  Modified date is not updated when
> an entry is modified the same day as when it was originally added, or
> if the modified date already has been bumped once on the date of the
> commit.  So you need to update for all entries which has either
> modification or entry date today... actually you probably need to take
> entries from the date before and after also due to timezone's.  But
> that should still reduce the number of entries that must bed update
> considerably.
> 
> Actually it should be rather simple to generate the real modification
> date for each entry using "cvs annotate vuln.xml"... I might play
> around with that later today :-).

I just had a test run of this code.  FreshPorts ignores any vuln that 
does not contain at least one date field that is within 2 days of the 
current date.  This can be overridden on the command line so that all 
entries are processed, regardless of date.

I'll move this to production soon.

cheers
-- 
Dan Langille : http://www.langille.org/
BSDCan - The Technical BSD Conference - http://www.bsdcan.org/