[Bug 236922] Virtio fails as QEMU-KVM guest with Q35 chipset on Ubuntu 18.04.2 LTS

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236922

--- Comment #44 from John Hartley <drum at graphica.com.au> ---
(In reply to Tommy P from comment #43)

Hi Tommy P,

thanks again for continuing to work on this.

I have applied a slight variation to what you posted, which did:

#if defined(DEV_NETMAP) && defined(WITH_PTNETMAP)

Conditional compilation rather than remove the netmap code.

See diffs here:

# diff sys/dev/virtio/network ~/virtio-12/sys/dev/virtio/network
diff sys/dev/virtio/network/if_vtnet.c
/home/jbh/virtio-12/sys/dev/virtio/network/if_vtnet.c
350c350
< #if defined(DEV_NETMAP) && defined(WITH_PTNETMAP)
---
> #ifdef DEV_NETMAP
367c367
< #if defined(DEV_NETMAP) && defined(WITH_PTNETMAP)
---
> #ifdef DEV_NETMAP
475c475
< #if defined(DEV_NETMAP) && defined(WITH_PTNETMAP)
---
> #ifdef DEV_NETMAP
507c507
< #if defined(DEV_NETMAP) && defined(WITH_PTNETMAP)
---
> #ifdef DEV_NETMAP
2031c2031
< #if defined(DEV_NETMAP) && defined(WITH_PTNETMAP)
---
> #ifdef DEV_NETMAP
2766c2766
< #if defined(DEV_NETMAP) && defined(WITH_PTNETMAP)
---
> #ifdef DEV_NETMAP
3070c3070
< #if defined(DEV_NETMAP) && defined(WITH_PTNETMAP)
---
> #ifdef DEV_NETMAP
3218c3218
< #if defined(DEV_NETMAP) && defined(WITH_PTNETMAP)
---
> #ifdef DEV_NETMAP
3409c3409
< #if defined(DEV_NETMAP) && defined(WITH_PTNETMAP)
---
> #ifdef DEV_NETMAP
diff sys/dev/virtio/network/if_vtnetvar.h
/home/jbh/virtio-12/sys/dev/virtio/network/if_vtnetvar.h
85c85
< #if defined(DEV_NETMAP) & defined(WITH_PTNETMAP)
---
> #ifdef DEV_NETMAP
124c124
< #if defined(DEV_NETMAP) && defined(WITH_PTNETMAP)

This is just a suggestion as it allows for easy "re-enablement" of netmap in
the event that Vincenzo re-adds "#define WITH_PTNETMAP" into
sys/dev/netmap/netmap_kern.h netmap parameter file.

In my testing I got clean compile across your, Brian's and Vincenzo's updates,
but did not get any VirtIO devices showing up :-( .  This is likely due to
either:
a. me having incorrectly apply update or other issue, due to all my
add/removing  and patching code
b. some other QEMU / Q35 version issues (which MattS has reported on other
defect thread).

Cheers,


John Hartley.

-- 
You are receiving this mail because:
You are the assignee for the bug.