[vm-bhyve] Windows 2012 and 2016 servers guests would not stop

[Paul Vixie]

Victor Sudakov wrote on 2019-04-22 21:13:
...
>>>>       sleep 1
...
>> i think this is worse than brutal, it's wrong. consider freebsd's own
>> work flow when trying to comply with the first soft shutdown it got:
>>
>> https://github.com/freebsd/freebsd/blob/master/sbin/reboot/reboot.c#L220
>>
>> this has bitten me more than once, because using "pageins" as a proxy
>> for "my server processes are busy trying to synchronize their user mode
>> state" is inaccurate. i think _any_ continuing I/O should be reason to
>> wait the full 60 seconds.
> 
> Would it be beneficial to just hack /usr/local/lib/vm-bhyve/vm-* ?

no, i really think the hypervisor should add i/o monitoring, so that if 
the soft shutdown signal is sent, the client kernel is allowed to keep 
running until either a really long timeout (60 seconds or more), but if 
it becomes quiet, then the hypervisor can exit sooner.

>> i agree with this.
> 
> Will you please support the bug report:
> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=237479

done.

-- 
P Vixie