emulated PCI device BAR size

[Rodney W. Grimes]

> On Sat, Mar 23, 2019 at 6:44 PM Jason Tubnor <jtubnor at gmail.com> wrote:
> >
> >
> >
> > On Sun., 24 Mar. 2019, 6:35 am Chuck Tuffli, <chuck at freebsd.org> wrote:
> >>
> >> On Mon, Mar 18, 2019 at 10:15 AM Chuck Tuffli <chuck at freebsd.org> wrote:
> >>
> >> >
> >> > So my question is how to best fix this. The easiest would be to add a
> >> > check to the BAR size calculation in pci_nvme.c along the lines of:
> >> >     #define NVME_MMIO_SPACE_MIN    (1 << 14)
> >> >     ...
> >> >     pci_membar_sz = MAX( <calculation based on queue count>,
> >> > NVME_MMIO_SPACE_MIN);
> >>
> >> I went down this route and have a patch up for review
> >> (https://reviews.freebsd.org/D19676) if anyone is interested.
> >>
> >> --chuck
> >
> >
> > I've built and installed this patch on FreeBSD 12.0-STABLE-amd64-20190314-r345117.  Testing occurred against Windows 10 Pro guest with a presented NVMe bhyve device and all IO transactions worked without issue.
> >
> > Can this be committed to head and MFD to 12-STABLE.  Thanks!
> 
> Committed with r345956. MFC in 2 weeks if nothing pops up. Thanks
> again for all your testing!

A small prod Chuck you should of mentioned Jason in the
commit message for his testing work.  I know it is easy
to forget this, but it is the right thing to do.

Jason,
  I'll thank you here, in a more personal maner, for working with
Chuck on getting this fixed.

Thanks,
-- 
Rod Grimes                                                 rgrimes at freebsd.org