[Bug 223531] Instant kernel panic on 'kldload virtio_console' on oVirt 3.5 VM
bugzilla-noreply at freebsd.org
bugzilla-noreply at freebsd.org
Sat Jan 13 21:40:34 UTC 2018
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223531
--- Comment #20 from commit-hook at freebsd.org ---
A commit references this bug:
Author: bryanv
Date: Sat Jan 13 21:39:46 UTC 2018
New revision: 327948
URL: https://svnweb.freebsd.org/changeset/base/327948
Log:
Fix possible panic when creating VirtIO console dev aliases
Since we have no control over the name, the MAKEDEV_CHECKNAME flag must be
used to return an error on an invalid (to devfs) name instead of panicing.
r305900 that originally added this feature also introduced a few other bugs:
- Proper locking not performed
- Theoretically broke the expectation that the control event buffer would
not span more than one pages, but did not update the CTASSERT that was
in place to prevent this. However, since the struct
virtio_console_control
and the bulk buffer together were quite small, this could not have
happened.
Also workaround an QEMU VirtIO spec violation in that it includes the NUL
terminator in the buffer length when the spec says it is not included.
PR: 223531
MFC after: 1 week
Changes:
head/sys/dev/virtio/console/virtio_console.c
--
You are receiving this mail because:
You are on the CC list for the bug.
More information about the freebsd-virtualization
mailing list