[Differential] [Request, 10 lines] D5276: hyperv/hn: Use taskqueue_enqueue()

sepherosa_gmail.com (Sepherosa Ziehau) phabric-noreply at FreeBSD.org
Sun Feb 14 08:57:25 UTC 2016


sepherosa_gmail.com created this revision.
sepherosa_gmail.com added reviewers: network, adrian, delphij, royger, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com.
sepherosa_gmail.com added subscribers: freebsd-net-list, freebsd-virtualization-list.

REVISION SUMMARY
  This also eases experiment on the non-fast taskqueue.

REVISION DETAIL
  https://reviews.freebsd.org/D5276

AFFECTED FILES
  sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c

CHANGE DETAILS
  diff --git a/sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c b/sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c
  --- a/sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c
  +++ b/sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c
  @@ -1549,7 +1549,7 @@
   			return;
   	}
   do_sched:
  -	taskqueue_enqueue_fast(sc->hn_tx_taskq, &sc->hn_start_task);
  +	taskqueue_enqueue(sc->hn_tx_taskq, &sc->hn_start_task);
   }
   
   static void
  @@ -1566,10 +1566,8 @@
   		atomic_clear_int(&ifp->if_drv_flags, IFF_DRV_OACTIVE);
   		sched = hn_start_locked(ifp, sc->hn_direct_tx_size);
   		NV_UNLOCK(sc);
  -		if (sched) {
  -			taskqueue_enqueue_fast(sc->hn_tx_taskq,
  -			    &sc->hn_start_task);
  -		}
  +		if (sched)
  +			taskqueue_enqueue(sc->hn_tx_taskq, &sc->hn_start_task);
   	} else {
   do_sched:
   		/*
  @@ -1579,7 +1577,7 @@
   		 * races.
   		 */
   		atomic_clear_int(&ifp->if_drv_flags, IFF_DRV_OACTIVE);
  -		taskqueue_enqueue_fast(sc->hn_tx_taskq, &sc->hn_txeof_task);
  +		taskqueue_enqueue(sc->hn_tx_taskq, &sc->hn_txeof_task);
   	}
   }

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: sepherosa_gmail.com, network, adrian, delphij, royger, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com
Cc: freebsd-virtualization-list, freebsd-net-list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D5276.13288.patch
Type: text/x-patch
Size: 983 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-virtualization/attachments/20160214/b55db293/attachment.bin>


More information about the freebsd-virtualization mailing list