[Differential] [Updated] D5185: tcp/lro: Allow network drivers to set the limit for TCP ACK/data segment aggregation limit

gallatin (Andrew Gallatin) phabric-noreply at FreeBSD.org
Thu Feb 4 15:57:30 UTC 2016

gallatin added a comment.

  It might be nice to make these general tunables that could be done centrally and apply to all drivers, but that's probably outside the scope of the review.

  sys/netinet/tcp_lro.c:655 Can you just initialize ack_append_limit to the max value for whatever type it is and eliminate the check for a 0 ack_append_limit?  That would eliminate one clause from this conditional.
  sys/netinet/tcp_lro.c:684 Rather than adding more clauses to this condition,  how would to feel about setting an append limit in bytes, and replacing the hard-coded 65535 with this new limit?   The default lro init would initialize the new limit to 65535.  And hn(4) would initialize it in terms of multiples of its MTU.



To: sepherosa_gmail.com, network, adrian, delphij, royger, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com, hselasky, np, transport, gallatin
Cc: freebsd-virtualization-list, freebsd-net-list

More information about the freebsd-virtualization mailing list