Docker: jail: name cannot be numeric fix

[Sergey Zakharchenko]

2015-10-27 19:12 GMT+03:00 Sergey Zakharchenko <doublef.mobile at gmail.com>:
> Mateusz,
>
>> What's the significance of said names?
>
> None that I know of; I'm new to Docker so I might be wrong though.
>
>> The issue here is that said id may contain to letters, effectivley
>> looking like a number
>
> ..the probability of that being (10/16)^12, which isn't too high but still
> significant...

A funny thing: Docker source (function GenerateRandomID in
pkg/stringid/stringid.go) actually checks for a fully numeric ID and
avoids it, because it causes other problems:

        // if we try to parse the truncated for as an int and we don't have
        // an error then the value is all numberic and causes issues when
        // used as a hostname. ref #3869

So the probability I mentioned is if fact zero and, ironically, fixing
this small kernel bug could actually 'unbreak' Docker. Adjusting
GenerateRandomID in the FreeBSD Docker port is another option,
possibly faster to get into production.

Best regards,

-- 
DoubleF