Rework hypervisor detection

[Jung-uk Kim]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2014-10-27 12:47:13 -0400, Conrad Meyer wrote:
> Hi John,
> 
> I don't have access to phabricator so I'll try and review in
> email.
> 
>> +#ifdef XEN +int vm_guest = VM_GUEST_XEN; +#else +int vm_guest =
>> VM_GUEST_NO; /* Running as virtual machine guest? */ +#endif
> 
> The whitespace between 'int' and 'vm_guest' in the second line
> seems wrong (extra space?).
> 
> For vmware_hvcall() in x86/include/vmware.h, are you sure the
> inline assembly is correct? Have you tried the detection on a
> VMware VM? VMware's documentation specifies the arguments in a
> different order[0], and at Isilon when we tried the port-based
> detection in a slightly older revision of CURRENT, it didn't work
> (IIRC).
> 
> Everything else looks good to me, thanks.
> 
> [0]:
> http://kb.vmware.com/selfservice/microsites/search.do?language=en_US&cmd=displayKC&externalId=1009458

I
> 
wrote the code and it worked for me at the time.  I'll try again soon.

Jung-uk Kim
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEbBAEBAgAGBQJUTn39AAoJEHyflib82/FGWt8H+IoPF03arSi2lAgT+LnVrKgj
x+r/yKfQ4+5/nxwRfvu/6FER+AUCWRYt+C12vnYdJwpx4iyspNi9FLDgyqpgtmgA
FQQr1ZYuOG8fHDln5gGxXG8p3VQBce5zaVHK7CHaLrgPMM1qY6OE35aSplzCIpsH
9QmlokW5gjaPvCt/EdCnbHB3nBZ2O8gpkd1GCr4OZwNerkmUmDL3dM08DgKVQsED
eeYhOKP6e4cLNG/1VGLqcMpMH93CYFmukOcLMpiNNaFwC2zEusah6X5e98bzeVxk
HcgMvB451OWEVoM93CoV86q3DTlxRthpwnuB06LfSDHSZRrRO4IqYR9Sj3OYFQ==
=/9eJ
-----END PGP SIGNATURE-----