[patch] VirtualBox-4.0.14 + FreeBSD/CURRENT + VIMAGE: crash on vm shutdown

[Mikolaj Golub]

Hi,

On Fri, 30 Mar 2012 10:13:57 +0200 Bernhard Froehlich wrote:

 BF> Sorry for the late response and thanks for the patch. Is this patch
 BF> still required for 4.1.8? My guess is yes but it would be great if you
 BF> could confirm that with the latest port.

Sorry, it required some time to check -- I upgraded my box to the latest
current and had some instabilities to fix before testing vbox.

So on the recent current and VirtualBox-4.1.10 (the latest version I have
found in the ports) the VBoxNetFlt patch is still required but VBoxNetAdp also
needs patching: I had a crash on vm start:

#0  doadump (textdump=-2022600704) at pcpu.h:244
#1  0x8051af69 in db_fncall (dummy1=1, dummy2=0, dummy3=-2127583648, dummy4=0xdcb61838 "")
    at /home/golub/freebsd/base/head/sys/ddb/db_command.c:573
#2  0x8051b361 in db_command (last_cmdp=0x811221fc, cmd_table=0x0, dopager=1)
    at /home/golub/freebsd/base/head/sys/ddb/db_command.c:449
#3  0x8051b4ba in db_command_loop () at /home/golub/freebsd/base/head/sys/ddb/db_command.c:502
#4  0x8051d4ad in db_trap (type=12, code=0)
    at /home/golub/freebsd/base/head/sys/ddb/db_main.c:229
#5  0x80a81d96 in kdb_trap (type=12, code=0, tf=0xdcb61ad4)
    at /home/golub/freebsd/base/head/sys/kern/subr_kdb.c:629
#6  0x80dd22af in trap_fatal (frame=0xdcb61ad4, eva=24)
    at /home/golub/freebsd/base/head/sys/i386/i386/trap.c:1014
#7  0x80dd2387 in trap_pfault (frame=0xdcb61ad4, usermode=0, eva=24)
    at /home/golub/freebsd/base/head/sys/i386/i386/trap.c:835
#8  0x80dd3451 in trap (frame=0xdcb61ad4)
    at /home/golub/freebsd/base/head/sys/i386/i386/trap.c:547
#9  0x80dbccac in calltrap () at /home/golub/freebsd/base/head/sys/i386/i386/exception.s:169
#10 0x80b0633e in ifindex_alloc_locked (idxp=0xdcb61b56)
    at /home/golub/freebsd/base/head/sys/net/if.c:279
#11 0x80b09172 in if_alloc (type=6 '\006') at /home/golub/freebsd/base/head/sys/net/if.c:435
#12 0x8b01e8e7 in vboxNetAdpOsCreate () from /boot/modules/vboxnetadp.ko
#13 0x8b01ef00 in vboxNetAdpCreate () from /boot/modules/vboxnetadp.ko
#14 0x8b01ecd8 in VBoxNetAdpFreeBSDCtrlioctl () from /boot/modules/vboxnetadp.ko
#15 0x8095c6bb in devfs_ioctl_f (fp=0x8b6f8118, com=3223352833, data=0x8b022360, 
    cred=0x87759b00, td=0x89fdf2e0)
    at /home/golub/freebsd/base/head/sys/fs/devfs/devfs_vnops.c:757
#16 0x80a9b4ed in kern_ioctl (td=0x89fdf2e0, fd=3, com=3223352833, data=0x8b022360 "vboxnet0")
    at file.h:287
#17 0x80a9b674 in sys_ioctl (td=0x89fdf2e0, uap=0xdcb61cec)
    at /home/golub/freebsd/base/head/sys/kern/sys_generic.c:691
#18 0x80dd29ae in syscall (frame=0xdcb61d28) at subr_syscall.c:135

I am attaching two patches: the first one is for VBoxNetFlt (the same I sent
to the list but against 4.1.10) and the second one for VBoxNetAdp (a fix for
the panic above).

 BF> Do you aggree that this patch is under MIT License so that I can push
 BF> it upstream?

Sure for both patches. Thanks for taking it!

-- 
Mikolaj Golub

-------------- next part --------------
A non-text attachment was scrubbed...
Name: VirtualBox-4.1.10.VBoxNetFlt.freebsd.VIMAGE.patch
Type: text/x-patch
Size: 1140 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-virtualization/attachments/20120401/00caaccf/VirtualBox-4.1.10.VBoxNetFlt.freebsd.VIMAGE.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: VirtualBox-4.1.10.VBoxNetAdp.freebsd.VIMAGE.patch
Type: text/x-patch
Size: 2620 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-virtualization/attachments/20120401/00caaccf/VirtualBox-4.1.10.VBoxNetAdp.freebsd.VIMAGE.bin