ucom modem issue on recent RELENG_8

[Hans Petter Selasky]

On Tuesday 26 April 2011 08:56:34 Hans Petter Selasky wrote:
> On Tuesday 26 April 2011 03:41:39 Mike Tancsa wrote:
> > Hi,
> > 
> > 	I have run into a problem where ucom no longer works with a recent
> > 	kernel
> > 
> > from this past week on RELENG_8. I tried the same setup with RELENG_8
> > from Feb 14th and it works as expected.  I am about to start narrowing
> > it down but was wondering if any one had any hints as to what to try ? 
> > The symptoms are that large packets fail.
> 
> There has been some EHCI patches in 8-stable recently. Else there hasn't
> been many changes at all with regard to USB.

Reviewing one of my patches, I think I might have introduced a small bug 
related to sending of ZLP's. Can you apply this patch and report back?


=== ehci.c
==================================================================
--- ehci.c      (revision 220904)
+++ ehci.c      (local)
@@ -1196,6 +1196,8 @@
                dt ^= 1;        /* short packet at the end */
        else if (actlen != xlen)
                dt ^= 1;        /* zero length packet at the end */
+       else if (xlen == 0)
+               dt ^= 1;        /* zero length transfer */
 
        xfer->endpoint->toggle_next ^= dt;


--HPS