usb/142957: patch for USB disk SYNCHRONIZE CACHE problem

[Tom Vijlbrief]

>Number:         142957
>Category:       usb
>Synopsis:       patch for USB disk SYNCHRONIZE CACHE problem
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    freebsd-usb
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jan 19 08:20:06 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Tom Vijlbrief
>Release:        8.0-RELEASE-p2
>Organization:
Home
>Environment:
FreeBSD nomadbsd.v7f.eu 8.0-RELEASE-p2 FreeBSD 8.0-RELEASE-p2 #3: Tue Jan 19 08:22:31 CET 2010     root at nomadbsd.v7f.eu:/usr/obj/usr/src/sys/TOM  i386

>Description:
When using a noname USB drive with ZFS the messages log is filled with:

Jan 18 21:18:53 nomadbsd kernel: (da0:umass-sim0:0:0:0): SYNCHRONIZE CACHE(10). CDB: 35 0 0 0 0 0 0 0 0 0
Jan 18 21:18:53 nomadbsd kernel: (da0:umass-sim0:0:0:0): CAM Status: SCSI Status Error
Jan 18 21:18:53 nomadbsd kernel: (da0:umass-sim0:0:0:0): SCSI Status: Check Condition
Jan 18 21:18:53 nomadbsd kernel: (da0:umass-sim0:0:0:0): ILLEGAL REQUEST asc:20,0
Jan 18 21:18:53 nomadbsd kernel: (da0:umass-sim0:0:0:0): Invalid command operation code
Jan 18 21:18:53 nomadbsd kernel: (da0:umass-sim0:0:0:0): Unretryable error

>How-To-Repeat:
Attach my USB drive and use ZFS
>Fix:
Apply this patch for adding a quirck specification to the usbdevs

Patch attached with submission follows:

*** sys/dev/usb/usbdevs.org	Tue Jan 19 08:38:49 2010
--- sys/dev/usb/usbdevs	Tue Jan 19 08:39:52 2010
***************
*** 1186,1191 ****
--- 1186,1192 ----
  
  /* DMI products */
  product DMI CFSM_RW		0xa109	CF/SM Reader/Writer
+ product DMI DISK		0x2bcf	Generic Disk
  
  /* DrayTek products */
  product DRAYTEK VIGOR550	0x0550	Vigor550
*** sys/dev/usb/storage/umass.c.org	Tue Jan 19 08:42:49 2010
--- sys/dev/usb/storage/umass.c	Tue Jan 19 08:43:00 2010
***************
*** 460,465 ****
--- 460,469 ----
  		UMASS_PROTO_SCSI,
  		NO_GETMAXLUN
  	},
+ 	{USB_VENDOR_DMI, USB_PRODUCT_DMI_DISK, RID_WILDCARD,
+ 		UMASS_PROTO_SCSI | UMASS_PROTO_BBB,
+ 		NO_SYNCHRONIZE_CACHE
+ 	},
  	{USB_VENDOR_EPSON, USB_PRODUCT_EPSON_STYLUS_875DC, RID_WILDCARD,
  		UMASS_PROTO_SCSI | UMASS_PROTO_CBI,
  		NO_INQUIRY


>Release-Note:
>Audit-Trail:
>Unformatted: