usb/127980: [QUIRK] Fix Samsung YP U2 MP3 player on 7.x and 8.x

[Ulrich Spörlein]

>Number:         127980
>Category:       usb
>Synopsis:       [QUIRK] Fix Samsung YP U2 MP3 player on 7.x and 8.x
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-usb
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Oct 09 18:00:06 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator:     Ulrich Spörlein
>Release:        FreeBSD 7.1-PRERELEASE i386
>Organization:
>Environment:
>Description:
In the early days of RELENG_7 the quirk below was required to avoid timeouts
with this MP3 player. But something changed in the USB code in the last few weeks,
so that this device no longer attaches. I also tried -CURRENT from early august.

It just stalls BBB transfers and I finally rebooted the box after two hours.
Unplugging the device *always* leads to a panic, as it is stuck somewhere in
CAM land. But I guess no one is interested in *that* backtrace ...
>How-To-Repeat:
>Fix:

The fix is rather trivial: Remove the quirk and the device attaches
successfully. (at least, if it is the only device on the bus)

cf usb/114154 (which should be closed, btw)

--- umass.diff begins here ---
Index: sys/dev/usb/umass.c
===================================================================
RCS file: /home/ncvs/src/sys/dev/usb/umass.c,v
retrieving revision 1.160.2.4
diff -u -p -r1.160.2.4 umass.c
--- sys/dev/usb/umass.c	28 Aug 2008 14:20:58 -0000	1.160.2.4
+++ sys/dev/usb/umass.c	8 Oct 2008 17:49:38 -0000
@@ -650,10 +650,6 @@ static struct umass_devdescr_t umass_dev
 	  UMASS_PROTO_SCSI | UMASS_PROTO_BBB,
 	  IGNORE_RESIDUE | NO_START_STOP
 	},
-	{ USB_VENDOR_SAMSUNG,  USB_PRODUCT_SAMSUNG_YP_U2, RID_WILDCARD,
-	  UMASS_PROTO_SCSI | UMASS_PROTO_BBB,
-	  SHUTTLE_INIT | NO_GETMAXLUN
-	},
 	{ USB_VENDOR_SAMSUNG_TECHWIN, USB_PRODUCT_SAMSUNG_TECHWIN_DIGIMAX_410, RID_WILDCARD,
 	  UMASS_PROTO_SCSI | UMASS_PROTO_BBB,
 	  NO_INQUIRY
Index: sys/dev/usb/usbdevs
===================================================================
RCS file: /home/ncvs/src/sys/dev/usb/usbdevs,v
retrieving revision 1.328.2.18
diff -u -p -r1.328.2.18 usbdevs
--- sys/dev/usb/usbdevs	28 Aug 2008 14:20:58 -0000	1.328.2.18
+++ sys/dev/usb/usbdevs	9 Oct 2008 17:55:09 -0000
@@ -1989,7 +1989,6 @@ product SAGEM XG76NA		0x0062	XG-76NA
 
 /* Samsung products */
 product SAMSUNG ML6060		0x3008	ML-6060 laser printer
-product SAMSUNG YP_U2		0x5050	YP-U2 MP3 Player
 product SAMSUNG I500		0x6601	I500 Palm USB Phone 
 
 /* Samsung Techwin products */
--- umass.diff ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted: