usb/78984: [umass] [patch] Creative MUVO umass failure

[Mark Kirkwood]

M. Warner Losh wrote:
> In message: <200804211030.m3LAU3Uo091913 at freefall.freebsd.org>
>             Mark Kirkwood <markir at paradise.net.nz> writes:
> : The following reply was made to PR usb/78984; it has been noted by GNATS.
> : 
> : From: Mark Kirkwood <markir at paradise.net.nz>
> : To: bug-followup at FreeBSD.org, bofh at m-wesemeyer.de
> : Cc:  
> : Subject: Re: usb/78984: [umass] [patch] Creative MUVO umass failure
> : Date: Mon, 21 Apr 2008 22:11:17 +1200
> : 
> :  I ran into this with 7-STABLE and a 128MB creatiev muvo. This slightly 
> :  updated patch seems to fix.
> :  ================================================================================
> :  *** sys/dev/usb/umass.c.orig    Mon Apr 21 18:17:08 2008
> :  --- sys/dev/usb/umass.c Mon Apr 21 18:20:31 2008
> :  ***************
> :  *** 374,379 ****
> :  --- 374,383 ----
> :        UMASS_PROTO_SCSI | UMASS_PROTO_BBB,
> :        FORCE_SHORT_INQUIRY | NO_START_STOP | IGNORE_RESIDUE
> :      },
> :  +   { USB_VENDOR_CREATIVE, USB_PRODUCT_CREATIVE_NOMAD, RID_WILDCARD,
> :  +     UMASS_PROTO_SCSI | UMASS_PROTO_BBB,
> :  +     READ_CAPACITY_OFFBY1
> :  +   },
> :      { USB_VENDOR_DESKNOTE, USB_PRODUCT_DESKNOTE_UCR_61S2B, RID_WILDCARD,
> :        UMASS_PROTO_SCSI | UMASS_PROTO_BBB,
> :        NO_QUIRKS
> :  ================================================================================
>
> Are all Creative nomad's off by one?  In linux, this quirk is used
> extremely rarely, and i don't think I see the nomad on the lists...
>
>
>   


Good point, the wildcard for all creative nomads is wrong (I've 
corrected the patch in the pr) - Interestingly I had the opportunity to 
try this device out in Linux the other day (Ubuntu 8.0.4) I got the 
error stack below...seems Linux needs the quirk for this guy as well!

-------------------------------------Ubuntu 
dmesg-------------------------------------------

[   11.975774] usb 2-1: new full speed USB device using uhci_hcd and 
address 2
[   11.996611] usb 2-1: configuration #1 chosen from 1 choice
[   12.199422] usbcore: registered new interface driver libusual
[   12.235825] Initializing USB Mass Storage driver...
[   12.237512] scsi2 : SCSI emulation for USB Mass Storage devices
[   12.239161] usbcore: registered new interface driver usb-storage
[   12.239171] USB Mass Storage support registered.
[   12.239333] usb-storage: device found at 2
[   12.239339] usb-storage: waiting for device to settle before scanning
[   14.930721] usb-storage: device scan complete
[   14.933726] scsi 2:0:0:0: Direct-Access     CREATIVE NOMAD_MUVO       
0001 PQ: 0 ANSI: 4
[   14.957715] sd 2:0:0:0: [sdb] 256001 512-byte hardware sectors (131 MB)
[   14.960641] sd 2:0:0:0: [sdb] Write Protect is off
[   14.960650] sd 2:0:0:0: [sdb] Mode Sense: 03 00 00 04
[   14.960656] sd 2:0:0:0: [sdb] Assuming drive cache: write through
[   14.978623] sd 2:0:0:0: [sdb] 256001 512-byte hardware sectors (131 MB)
[   14.981610] sd 2:0:0:0: [sdb] Write Protect is off
[   14.981619] sd 2:0:0:0: [sdb] Mode Sense: 03 00 00 04
[   14.981625] sd 2:0:0:0: [sdb] Assuming drive cache: write through
[   14.981635]  sdb: sdb1
[   14.988768] sd 2:0:0:0: [sdb] Attached SCSI removable disk
[   14.988857] sd 2:0:0:0: Attached scsi generic sg2 type 0
[   15.401063] end_request: I/O error, dev sdb, sector 256000
[   15.401076] Buffer I/O error on device sdb, logical block 256000