usb/119945: rum device in hostap mode, cause kernel core dump.

[Y.Okabe]

>Number:         119945
>Category:       usb
>Synopsis:       rum device in hostap mode, cause kernel core dump.
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    freebsd-usb
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jan 24 16:40:02 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator:     Y.Okabe
>Release:        7.0-PRERELEASE
>Organization:
>Environment:
FreeBSD 7.0-PRERELEASE FreeBSD 7.0-PRERELEASE

CPU: VIA C7 Esther+RNG+AES+AES-CTR+SHA1+SHA256+RSA (1500.00-MHz 686-class CPU)
Origin = "CentaurHauls" Id = 0x6d0 Stepping = 0
Features=0xa7c9bbff<FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,CMOV,PAT,CLFLUSH,ACPI,MMX,FXSR,SSE,SSE2,TM,PBE>
Features2=0x4181<SSE3,EST,TM2,xTPR>

dmesg follow:

uhub4: <VIA EHCI root hub, class 9/0, rev 2.00/1.00, addr 1> on usb4
uhub4: 8 ports with 8 removable, self powered
rum0: <buffalo WLI-U2-SG54HP, class 0/0, rev 2.00/0.01, addr 2> on uhub4
rum0: MAC/BBP RT2573 (rev 0x2573a), RF RT2528
rum0: Ethernet address: 00:16:xx:xx:xx:xx
rum0: if_start running deferred for Giant

 
>Description:
I made rum device into hostap mode. 
When receive some packet by rum device,
kernel was panic and core dumped at module uhci.ko.

>How-To-Repeat:
1. install GENERIC kernel for RENENG_7,
2. configure hostapd using rum0.
3. setup rum0 and wired lan ingerface bridge
   i.e. run ifconfig bridge0 create
        run ifconfig bridge0 addm rum0 addm eth0
        run ifconfig bridge0 inet 192.168.1.9/24
4. run hostapd.
5. accsess wlan client this hostap accces point
    (by WPA-PSK, WPA-AES, WPA2-AES, etc...) 
6. some packet send, kernel panic.
>Fix:
rum_free_tx_list function on if_rum.c , at the OpenBSD current source  is

--------------- openbsd if_rum.c start --------------------------------
void
rum_free_tx_list(struct rum_softc *sc)
{
	int i;

	for (i = 0; i < RUM_TX_LIST_COUNT; i++) {
		struct rum_tx_data *data = &sc->tx_data[i];

		if (data->xfer != NULL) {
			usbd_free_xfer(data->xfer);
			data->xfer = NULL;
		}
		/*
		 * The node has already been freed at that point so don't call
		 * ieee80211_release_node() here.
		 */
		data->ni = NULL;
	}
}
--------------- openbsd if_rum.c end --------------------------------



therefor, freebsd's rum_free_tx_list function at if_rum.c 
/usr/src/sys/dev/usb/if_rum.c at line 650

static void
rum_free_tx_list(struct rum_softc *sc)
{
	struct rum_tx_data *data;
	int i;

	for (i = 0; i < RUM_TX_LIST_COUNT; i++) {
		data = &sc->tx_data[i];

		if (data->xfer != NULL) {
			usbd_free_xfer(data->xfer);
			data->xfer = NULL;
		}

		if (data->ni != NULL) {
-			ieee80211_free_node(data->ni);
+                       /*ieee80211_free_node(data->ni);*/
			data->ni = NULL;
		}
	}
}

--------------------------------------------------------------------

I don't know this patch's work reason.

but, hostapd can work at patched kernel.



>Release-Note:
>Audit-Trail:
>Unformatted: