usb/119653: iriver s7 player sync cache error patch

[lazyklimm]

>Number:         119653
>Category:       usb
>Synopsis:       iriver s7 player sync cache error patch
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-usb
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jan 14 09:30:03 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator:     lazyklimm
>Release:        RELENG_7
>Organization:
>Environment:
FreeBSD 7.0-PRERELEASE #1
>Description:
Sync cache error when iRriver S7 flash player connected


umass0: <iriver Limited iriver S7, class 0/0, rev 2.00/1.00, addr 2> on uhub3
da0 at umass-sim0 bus 0 target 0 lun 0
da0: <iriver S7 0.83> Removable Direct Access SCSI-2 device 
da0: 40.000MB/s transfers
da0: 973MB (1992704 512 byte sectors: 64H 32S/T 973C)
umass0: Phase Error, residue = 0
(da0:umass-sim0:0:0:0): Synchronize cache failed, status == 0x4, scsi status == 0x0
umass0: Phase Error, residue = 0
(da0:umass-sim0:0:0:0): Synchronize cache failed, status == 0x4, scsi status == 0x0
umass0: Phase Error, residue = 0
(da0:umass-sim0:0:0:0): Synchronize cache failed, status == 0x4, scsi status == 0x0
umass0: Phase Error, residue = 0
(da0:umass-sim0:0:0:0): Synchronize cache failed, status == 0x4, scsi status == 0x0

>How-To-Repeat:

>Fix:
patch included below

I think that we need to do something like that
		{T_DIRECT, SIP_MEDIA_REMOVABLE, "iriver", "*","*"},DA_Q_NO_SYNC_CACHE
because it seems to be common iRivers' error

Patch attached with submission follows:

--- sys/cam/scsi/scsi_da.c.orig	2008-01-14 10:30:42.000000000 +0300
+++ sys/cam/scsi/scsi_da.c	2008-01-14 10:32:46.000000000 +0300
@@ -449,6 +449,13 @@
 	},
 	{
 		/*
+		 * iRiver S7 MP3 player
+		 */
+		{T_DIRECT, SIP_MEDIA_REMOVABLE, "iriver", "S7*",
+		"*"}, /*quirks*/ DA_Q_NO_SYNC_CACHE
+	},
+	{
+		/*
 		 * iRiver H10 MP3 player
 		 * PR: usb/102547
 		 */


>Release-Note:
>Audit-Trail:
>Unformatted: