usb/114068: Problems with connection of the umass device (Samsung VY-H350 Voice recorder)

[Andrew Muhametshin]

>Number:         114068
>Category:       usb
>Synopsis:       Problems with connection of the umass device (Samsung VY-H350 Voice recorder)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-usb
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jun 27 14:10:02 GMT 2007
>Closed-Date:
>Last-Modified:
>Originator:     Andrew Muhametshin
>Release:        FreeBSD-6.2-STABLE
>Organization:
>Environment:
$ uname -a
FreeBSD inspirra.localdomain 6.2-STABLE FreeBSD 6.2-STABLE #7: Tue Jun 19 08:38:32 MSD 2007     root at inspirra.localdomain:/SHARED/obj.inspirra/usr/src/sys/INSPIRRA  i386
>Description:
After connection of the device (Samsung VY-H350 Voice recorder):

kernel: umass0: <Samsung product 0x500b, class 0/0, rev 1.10/1.00, addr 125>
kernel: umass0:  SCSI over Bulk-Only; quirks = 0x0000
kernel: umass0:6:0:-1: Attached to scbus6
kernel: (da0:umass-sim0:0:0:0): got CAM status 0x4
kernel: (da0:umass-sim0:0:0:0): fatal error, failed to attach to device
kernel: (da0:umass-sim0:0:0:0): lost device
kernel: (da0:umass-sim0:0:0:0): removing device entry 


I have found the description (and solution) similar problems with not supported umass-devices, here:
http://root.org/~nate/freebsd/scsi/quirks.html
and here:
http://www.freebsd.org/cgi/query-pr.cgi?pr=65436

By analogy, has tried to create patch:
============================START====================================
*** sys/dev/usb/usbdevs.orig        Tue Jun 19 09:34:56 2007
--- sys/dev/usb/usbdevs     Tue Jun 19 06:21:10 2007
***************
*** 1679,1684 ****
--- 1679,1685 ----

  /* Samsung products */
  product SAMSUNG ML6060                0x3008  ML-6060 laser printer
+ product SAMSUNG VYH350                0x500b  VY-H350 Voice recorder

  /* SanDisk products */
  product SANDISK SDDR05A               0x0001  ImageMate SDDR-05a
*** src/sys/cam/scsi/scsi_da.c.orig      Tue Jun 19 05:14:52 2007
--- src/sys/cam/scsi/scsi_da.c   Tue Jun 19 09:27:35 2007
***************
*** 475,480 ****
--- 475,487 ----
                {T_DIRECT, SIP_MEDIA_REMOVABLE, "EM732X", "MP3 Player*",
                "1.0"}, /*quirks*/ DA_Q_NO_SYNC_CACHE
        },
+       {
+               /*
+                * SAMSUNG VY-H350 1.00 Voice Recorder
+                */
+               {T_DIRECT, SIP_MEDIA_REMOVABLE, "*", "VY-H350*", "*"},
+               /*quirks*/ DA_Q_NO_SYNC_CACHE
+       },
  };

  static        disk_strategy_t dastrategy;
*** sys/dev/usb/umass.c.orig        Tue Jun 19 09:32:03 2007
--- sys/dev/usb/umass.c     Tue Jun 19 09:32:25 2007
***************
*** 540,545 ****
--- 540,549 ----
          UMASS_PROTO_ATAPI | UMASS_PROTO_CBI_I,
          FORCE_SHORT_INQUIRY
        },
+       { USB_VENDOR_SAMSUNG, USB_PRODUCT_SAMSUNG_VYH350, RID_WILDCARD,
+         UMASS_PROTO_SCSI | UMASS_PROTO_BBB,
+         IGNORE_RESIDUE
+       },
        { VID_EOT, PID_EOT, RID_EOT, 0, 0 }
  };
============================STOP=====================================

I have applied my patch, and have rebuild a kernel... But unfortunately, my patch has not given result.
Where I have made a mistake? 

Connection of the device after my patch:
kernel: umass0: <Samsung VY-H350 Voice recorder, class 0/0, rev 
1.10/1.00, addr 125>
kernel: umass0:  SCSI over Bulk-Only; quirks = 0x0080
kernel: umass0:6:0:-1: Attached to scbus6
kernel: (da0:umass-sim0:0:0:0): got CAM status 0x4
kernel: (da0:umass-sim0:0:0:0): fatal error, failed to attach to device
kernel: (da0:umass-sim0:0:0:0): lost device
kernel: (da0:umass-sim0:0:0:0): removing device entry

$ usbdevs -v
Controller /dev/usb0:
addr 125: full speed, self powered, config 1, VY-H350 Voice recorder(0x500b), Samsung(0x04e8), rev 1.00
addr 126: full speed, power 100 mA, config 1, Jabra - A320s(0x2101), Broadcom Corp(0x0a5c), rev 1.00
addr 127: full speed, self powered, config 1, OHCI root hub(0x0000), nVidia(0x0000), rev 1.00
 port 1 powered
 port 2 powered
 port 3 powered
 port 4 powered
 port 5 addr 126: full speed, power 100 mA, config 1, Jabra - A320s(0x2101), Broadcom Corp(0x0a5c), rev 1.00
 port 6 addr 125: full speed, self powered, config 1, VY-H350 Voice recorder(0x500b), Samsung(0x04e8), rev 1.00
 port 7 powered
 port 8 powered


>How-To-Repeat:

>Fix:


>Release-Note:
>Audit-Trail:
>Unformatted: