usb/108719: commit references a PR

[dfilter service]

The following reply was made to PR usb/108719; it has been noted by GNATS.

From: dfilter at FreeBSD.ORG (dfilter service)
To: bug-followup at FreeBSD.org
Cc:  
Subject: Re: usb/108719: commit references a PR
Date: Sat,  3 Feb 2007 16:19:45 +0000 (UTC)

 imp         2007-02-03 16:19:28 UTC
 
   FreeBSD src repository
 
   Modified files:
     sys/dev/usb          uhub.c 
   Log:
   Fix memory leak of devinfo.  The leak itself was documented in
   PR/108719, but there's a simpler fix: free it after it is used, and
   then get rid of the redundant frees this causes.  Other leaks in this
   PR not yet fixed.
   
   While I'm here, remove NetBSD/OpenBSD code and some of the portability
   #defines that were getting in the way of understanding this code.  The
   devinfo bug was harder to spot because one needed to know that
   device_set_desc_copy() was used inside of one of them (one that didn't
   take an argument!).
   
   Prefer device_printf(sc->sc_dev, "...") to printf("%s:...",
   device_get_nameunit(sc->sc_dev)).  This saves almost 300 bytes.
   
   PR: 108719
   Submitted by: Antoine Brodin
   
   Revision  Changes    Path
   1.73      +66 -122   src/sys/dev/usb/uhub.c
 _______________________________________________
 cvs-all at freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe at freebsd.org"