usb/107101: [umass] [patch] Quirk for Denver MP3 player

[Ed Schouten]

>Number:         107101
>Category:       usb
>Synopsis:       [umass] [patch] Quirk for Denver MP3 player
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-usb
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Dec 22 16:00:33 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator:     Ed Schouten
>Release:        FreeBSD 6.2-PRERELEASE i386
>Organization:
>Environment:
System 1: FreeBSD palm.hoeg.nl 6.2-PRERELEASE FreeBSD 6.2-PRERELEASE #0: Sun Dec 10 13:48:08 CET 2006 root at palm.hoeg.nl:/usr/obj/usr/src/sys/PALM i386
System 2: FreeBSD foxtrot.fxq.nl 5.5-STABLE FreeBSD 5.5-STABLE #0: Fri Dec 22 16:10:44 CET 2006 root at foxtrot.fxq.nl:/usr/obj/usr/src/sys/FOXTROT i386
>Description:
I have two desktops running FreeBSD. One is running FreeBSD
6.2-PRERELEASE and the other one 5.5-STABLE. When I plug in this really
awful MP3 player in one of the machines, I get a lot of dmesg spam. The
5.5 machine even suddenly reboots. The messages look like this:

| umass0: vendor 0x10d6 USB MASS STORAGE CLASS, rev 1.10/1.00, addr 2
| da0 at umass-sim0 bus 0 target 0 lun 0
| da0: <DENVER MP3 PLAYER 1.00> Removable Direct Access SCSI-0 device 
| da0: 1.000MB/s transfers
| da0: 499MB (1023713 512 byte sectors: 64H 32S/T 499C)
| umass0: BBB reset failed, STALLED
| umass0: BBB bulk-in clear stall failed, STALLED
| umass0: BBB bulk-out clear stall failed, STALLED
| (da0:umass-sim0:0:0:0): Synchronize cache failed, status == 0x4, scsi status == 0x0
| umass0: BBB reset failed, STALLED
| umass0: BBB bulk-in clear stall failed, STALLED
| umass0: BBB bulk-out clear stall failed, STALLED
| ...
| Opened disk da0 -> 5
| umass0: BBB reset failed, STALLED
| umass0: BBB bulk-in clear stall failed, STALLED
| umass0: BBB bulk-out clear stall failed, STALLED
| ...
| umass0: at uhub0 port 2 (addr 2) disconnected
| (da0:umass-sim0:0:0:0): lost device
| (da0:dead_sim0:0:0:0): removing device entry
| Opened disk da0 -> 22
| umass0: detached

>How-To-Repeat:
Plug in a Denver MP3 player.
>Fix:
After applying the patch below, the dmesg output will look like this:

| umass0: vendor 0x10d6 USB MASS STORAGE CLASS, rev 1.10/1.00, addr 2
| da0 at umass-sim0 bus 0 target 0 lun 0
| da0: <DENVER MP3 PLAYER 1.00> Removable Direct Access SCSI-0 device 
| da0: 1.000MB/s transfers
| da0: 499MB (1023713 512 byte sectors: 64H 32S/T 499C)
| GEOM_LABEL: Label for provider da0s1 is label/mp3speler.

--- scsi_da.c	Fri Dec 22 16:25:00 2006
+++ scsi_da.c	Fri Dec 22 16:26:41 2006
@@ -458,7 +458,15 @@
 		 */
 		{T_DIRECT, SIP_MEDIA_REMOVABLE, "iriver", "H10*",
 		"*"}, /*quirks*/ DA_Q_NO_SYNC_CACHE
-       },
+	},
+	{
+		/*
+		 * Denver MP3 player
+		 * PR: usb/xxxxxx
+		 */
+		{T_DIRECT, SIP_MEDIA_REMOVABLE, "DENVER", "MP3 PLAYER",
+		"*"}, /*quirks*/ DA_Q_NO_SYNC_CACHE
+	},
 };
 
 static	disk_strategy_t	dastrategy;
>Release-Note:
>Audit-Trail:
>Unformatted: