kern/63837: [patch] USB: hid_is_collection() only looks for the first item

John Baldwin jhb at FreeBSD.org
Wed Nov 17 07:30:26 PST 2004


The following reply was made to PR kern/63837; it has been noted by GNATS.

From: John Baldwin <jhb at FreeBSD.org>
To: freebsd-gnats-submit at FreeBSD.org, nivit at email.it
Cc:  
Subject: Re: kern/63837: [patch] USB: hid_is_collection() only looks for the first item
Date: Wed, 17 Nov 2004 09:59:20 -0500

 So, I think that the first part of the patch (setting h.report_ID to zero) is 
 not needed.  Basically, AFAICT, the effect of the patch is that 
 hid_report_size() will now return the ID of the first device of a given kind 
 rather than the last such device.  This seems to be a horrible interface 
 fwiw, and while this hack might work, I think the real fix is to adopt some 
 of the changes NetBSD made with their uhiddev.
 
 -- 
 John Baldwin <jhb at FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
 "Power Users Use the Power to Serve"  =  http://www.FreeBSD.org


More information about the freebsd-usb mailing list