FW: [Diffusion] rS136151: - Estimate the amount of data in flight in sack recovery and use it

Scheffenegger, Richard Richard.Scheffenegger at netapp.com
Mon Dec 24 01:04:37 UTC 2018

rscheff_gmx.at raised a concern with this commit.
rscheff_gmx.at added a comment.

  The variable sack_newdata really is "RecoveryPoint" in RFC3517/RFC6675 when in SACK context, while RFC3782 calls this "recover" in the NewReno context.

  However, this variable really tracks the same point in the sequence space, which is the value of snd_max  when initiating FastRecovery. And that is true for both NewReno and SACK.

  It makes no sense to track the same variable, for the same purpose, under two different names in TCPCB.

  Suggest to replace all uses of sack_newdata with snd_recover.

  rscheff_gmx.at (Auditor)



To: rscheff_gmx.at
Cc: rscheff_gmx.at

More information about the freebsd-transport mailing list