[Bug 230888] Missing 64 bit atomic functions for i386 (libatomic)

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=230888

Mikhail Teterin <mi at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mi at FreeBSD.org

--- Comment #21 from Mikhail Teterin <mi at FreeBSD.org> ---
(In reply to David Chisnall from comment #3)
> Is there a reason, given that LLVM's atomic.c is in contrib,
> that we don't just connect it to the libgcc_s build?

Based on David's suggestion, I did this:

--- lib/libcompiler_rt/Makefile.inc     (revision 359474)
+++ lib/libcompiler_rt/Makefile.inc     (working copy)
@@ -18,6 +18,7 @@
 SRCF+=         ashlti3
 SRCF+=         ashrdi3
 SRCF+=         ashrti3
+SRCF+=         atomic
 SRCF+=         clear_cache
 SRCF+=         clzdi2
 SRCF+=         clzsi2


rebuilt the world, and was then able to build lang/spidermonkey60 using the
base cc -- instead of dragging-in the gcc-suit:

--- Makefile    (revision 529979)
+++ Makefile    (working copy)
@@ -53,11 +53,6 @@
 CONFIGURE_TARGET=x86_64-portbld-freebsd${OSREL}
 .endif

-.if ${ARCH} == i386
-# ld: error: undefined symbol: __atomic_load
-USE_GCC=       9+
-.endif
-
 post-install:
        ${RM} ${STAGEDIR}${PREFIX}/lib/libjs_static.ajs
        ${LN} -fs libmozjs-${SP_VER}.so
${STAGEDIR}${PREFIX}/lib/libmozjs-${SP_VER}.so.1

Maybe, this should be done until an alternative is found?

The ticket is 1.5 years old and the "just build using gcc" is not a good
solution -- especially for those older (and slower) i386-systems we're
concerned about.

-- 
You are receiving this mail because:
You are the assignee for the bug.