[Bug 236582] Enable LLVM openmp on i386

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236582

Dimitry Andric <dim at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |emaste at freebsd.org

--- Comment #2 from Dimitry Andric <dim at FreeBSD.org> ---
Unfortunately it does not compile for our old default i486 CPU:

--- kmp_csupport.pico ---
/usr/src/contrib/openmp/runtime/src/kmp_csupport.cpp:565:7: error: '_mm_setcsr'
needs target feature sse
      __kmp_load_mxcsr(&serial_team->t.t_mxcsr);
      ^
/usr/src/contrib/openmp/runtime/src/kmp.h:3669:29: note: expanded from macro
'__kmp_load_mxcsr'
#define __kmp_load_mxcsr(p) _mm_setcsr(*(p))
                            ^
1 error generated.

So we can't unconditionally apply this to the i386 arch. Personally I'd be in
favor of raising the requirements for i386 to having at least SSE2, but that is
going to get lots of pushback from people that like to run old hardware. :)

Maybe there is some way to detect the actual CPU or CPUTYPE setting at build
time, and trigger on this.

Note also that the patch from ports r447281 is maybe not entirely correct, in
the sense that it enables code also for arm, aarch and mips.  I have no idea at
all whether those are supported in any way.

-- 
You are receiving this mail because:
You are the assignee for the bug.