External GCC Update

[Rodney W. Grimes]

> On Fri, Feb 22, 2019, 5:09 PM John Baldwin <jhb at freebsd.org> wrote:
> 
> > On 2/22/19 11:45 AM, Rodney W. Grimes wrote:
> > >> I was recently able to install base/binutils and base/gcc into an amd64
> > VM
> > >> and do a self-hosted build and install.  Some of the port patches have
> > been
> > >> committed from this, but I have some source patches before the final
> > ports
> > >> patches can be finished.
> > >>
> > >> The source patches are here:
> > >> https://github.com/bsdjhb/freebsd/compare/master...base_gcc
> > >
> > > Phabricator?
> >
> > Eventually, wanted a first cut of the entire patchset in context to see if
> > folks run screaming or not.

Huh? It is 5 files and not even 200 lines of diff???
My first Phab review for CPU topology was 10 files and over 300 lines.

> 
> Thank you. Phabricator isn't good with larger patches. Git let's me see
> things in a number of different views that are hard with the one size fits
> all phab ui.

Its rather hypocritical for core to announce a "recomendation to do reviews,
and the tool of choice is phabricator" and then have 2 core team members
advocate a code review in git just a short time later.

This sets bad examples from the top :-(

> Warner
> > John Baldwin
-- 
Rod Grimes                                                 rgrimes at freebsd.org