[Bug 234671] clang faults while compiling new GlusterFS source code

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234671

Dimitry Andric <dim at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Open                        |In Progress

--- Comment #6 from Dimitry Andric <dim at FreeBSD.org> ---
After merging the upstream fixes, clang won't crash anymore with a fatal error.
 It still will refuse to compile the glfs.c file though, now with:

error: versioned symbol glfs_upcall_register@@GFAPI_3.13.0 must be defined
error: versioned symbol glfs_upcall_unregister@@GFAPI_3.13.0 must be defined
2 errors generated.

Indeed, this is an error in the code, which seems to have been fixed in this
upstream commit (together with a lot of other symbol breakage):

https://github.com/gluster/glusterfs/commit/b4ce5e090dee2afc9ed0c86456a54f76a2bb6563

Can you try applying that, or at least parts of it?  Alternatively, a minimal
fix is:

--- a/glfs.c       2019-01-10 08:57:50.000000000 +0100
+++ b/glfs.c       2019-02-16 21:45:03.999966000 +0100
@@ -48952,7 +48952,7 @@
 GFAPI_SYMVER_PUBLIC_DEFAULT(glfs_sysrq, 3.10.0);

 int
-glfs_upcall_register (struct glfs *fs, uint32_t event_list,
+pub_glfs_upcall_register (struct glfs *fs, uint32_t event_list,
                       glfs_upcall_cbk cbk, void *data)
 {
         int ret = 0;
@@ -49003,7 +49003,7 @@
 }
 GFAPI_SYMVER_PUBLIC_DEFAULT(glfs_upcall_register, 3.13.0);

-int glfs_upcall_unregister (struct glfs *fs, uint32_t event_list)
+int pub_glfs_upcall_unregister (struct glfs *fs, uint32_t event_list)
 {
         int ret = 0;
         /* list of supported upcall events */

-- 
You are receiving this mail because:
You are on the CC list for the bug.