stable/11 -r308135 Build for RPI2 failed for: . . ./bcm2835_ft5406.c:65:10: fatal error: 'mbox_if.h' file not found [Fixed]

[Mark Millard]

On 2016-Nov-2, at 12:16 PM, Mark Millard <markmi at dsl-only.net> wrote:

> Quick top post reporting that a build-order-race for -j use seems likely: the clean-then-build sequence
> 
>> Command: env __MAKE_CONF=/root/src.configs/make.conf SRC_ENV_CONF=/root/src.configs/src.conf.rpi2-clang-bootstrap.amd64-host WITH_META_MODE=yes MAKEOBJDIRPREFIX=/usr/obj/rpi2_clang make cleanworld
>> 
>> Command: env __MAKE_CONF=/root/src.configs/make.conf SRC_ENV_CONF=/root/src.configs/src.conf.rpi2-clang-bootstrap.amd64-host WITH_META_MODE=yes MAKEOBJDIRPREFIX=/usr/obj/rpi2_clang make -j 5 buildworld buildkernel
> 
> that used -j 5 for buildworld buildkernel got the problem again. But following that failure by doing just buildkernel without the -j 5:
> 
>> Command: env __MAKE_CONF=/root/src.configs/make.conf SRC_ENV_CONF=/root/src.configs/src.conf.rpi2-clang-bootstrap.amd64-host WITH_META_MODE=yes MAKEOBJDIRPREFIX=/usr/obj/rpi2_clang make buildkernel
> 
> completed the rest of the build just fine, creating the previously-missing file before trying to use it.
> 
> 
> ===
> Mark Millard
> markmi at dsl-only.net
> 
> On 2016-Nov-2, at 3:13 AM, Mark Millard <markmi at dsl-only.net> wrote:
> 
>> Lack of dependency? Race? (I've not isolated why this happened yet but I was using -j 5 for buildworld buildkernel .)
>> 
>> This was a cross-build attempt from an amd64 context:
>> 
>> # uname -apKU
>> FreeBSD FreeBSDx64 11.0-STABLE FreeBSD 11.0-STABLE #1 r308135M: Tue Nov  1 23:48:47 PDT 2016     root at FreeBSDx64:/usr/obj/amd64_clang/amd64.amd64/usr/src/sys/GENERIC-NODBG  amd64 amd64 1100506 1100506
>> 
>> # svnlite info /usr/src/ | grep "Re[lv]"
>> Relative URL: ^/stable/11
>> Revision: 308135
>> Last Changed Rev: 308135
>> 
>> # find /usr/src/sys/ -name "*files*" -exec grep mbox_if {} \; -print | more
>> dev/mbox/mbox_if.m                              standard
>> /usr/src/sys/arm/broadcom/bcm2835/files.bcm283x
>> dev/mbox/mbox_if.m                              optional        ti_mbox
>> /usr/src/sys/arm/ti/files.ti
>> 
>> # find /usr/obj/rpi2_clang/arm.armv6/ -name mbox_if.h -print | more                                                                                                                                                                                                      
>> #
>> 
>> (So no mbox_if.h file is present in the build tree.)
>> 
>> # head ~/sys_typescripts/typescript_make_rpi2_nodebug_clang_bootstrap-amd64-host-2016-11-02:00:59:43
>> Script started on Wed Nov  2 00:59:43 2016
>> Command: env __MAKE_CONF=/root/src.configs/make.conf SRC_ENV_CONF=/root/src.configs/src.conf.rpi2-clang-bootstrap.amd64-host WITH_META_MODE=yes MAKEOBJDIRPREFIX=/usr/obj/rpi2_clang make -j 5 buildworld buildkernel
>> . . .
>> --- all_subdir_rpi_ft5406 ---
>> --- bcm2835_ft5406.o ---
>> /usr/src/sys/modules/rpi_ft5406/../../arm/broadcom/bcm2835//bcm2835_ft5406.c:65:10: fatal error: 'mbox_if.h' file not found
>> #include "mbox_if.h"
>>        ^
>> 1 error generated.
>> *** [bcm2835_ft5406.o] Error code 1
. . .

Looks like stable/11 -r308655 fix this. (-r308581 for head.) :

Author: gonzo
Date: Mon Nov 14 22:39:33 2016
New Revision: 308655
URL: 
https://svnweb.freebsd.org/changeset/base/308655


Log:
  MFC r308581:
  
  [rpi_ft5406] Add missing dependency on mbox_if.h
  
  Submitted by:	hselasky

Modified:
  stable/11/sys/modules/rpi_ft5406/Makefile
Directory Properties:
  stable/11/   (props changed)

Modified: stable/11/sys/modules/rpi_ft5406/Makefile
==============================================================================
--- stable/11/sys/modules/rpi_ft5406/Makefile	Mon Nov 14 22:33:57 2016	(r308654)
+++ stable/11/sys/modules/rpi_ft5406/Makefile	Mon Nov 14 22:39:33 2016	(r308655)
@@ -5,6 +5,6 @@
 KMOD=	rpi_ft5406
 SRCS=	bcm2835_ft5406.c
 
-SRCS+= bus_if.h device_if.h ofw_bus_if.h
+SRCS+= bus_if.h device_if.h mbox_if.h ofw_bus_if.h
 
 .include <bsd.kmod.mk>


===
Mark Millard
markmi at dsl-only.net