[Differential] [Commented On] D2187: Ensure cross assembler, linker and objcopy are used for the build32 stage

dim (Dimitry Andric) phabric-noreply at FreeBSD.org
Tue Mar 31 21:07:23 UTC 2015


dim added inline comments.

INLINE COMMENTS
  Makefile.inc1:416 These are also unconditionally used in the previous block for WMAKENV, e.g.:
  
  ```
  WMAKEENV+=      CC="${XCC} ${XCFLAGS}" CXX="${XCXX} ${XCFLAGS} ${XCXXFLAGS}" \
                  DEPFLAGS="${DEPFLAGS}" \
                  CPP="${XCPP} ${XCFLAGS}" \
                  AS="${XAS}" AR="${XAR}" LD="${XLD}" NM=${XNM} \
                  OBJDUMP=${XOBJDUMP} OBJCOPY="${XOBJCOPY}" \
                  RANLIB=${XRANLIB} STRINGS=${XSTRINGS} \
                  SIZE="${XSIZE}"
  ```
  
  and just before that, they are unconditionally defined:
  
  ```
  XCOMPILERS=     CC CXX CPP
  .for COMPILER in ${XCOMPILERS}
  .if defined(CROSS_COMPILER_PREFIX)
  X${COMPILER}?=  ${CROSS_COMPILER_PREFIX}${${COMPILER}}
  .else
  X${COMPILER}?=  ${${COMPILER}}
  .endif
  .endfor
  XBINUTILS=      AS AR LD NM OBJCOPY OBJDUMP RANLIB SIZE STRINGS
  .for BINUTIL in ${XBINUTILS}
  .if defined(CROSS_BINUTILS_PREFIX)
  X${BINUTIL}?=   ${CROSS_BINUTILS_PREFIX}${${BINUTIL}}
  .else
  X${BINUTIL}?=   ${${BINUTIL}}
  .endif
  .endfor
  ```
  
  So I think it is unnecessary to check them again.

REVISION DETAIL
  https://reviews.freebsd.org/D2187

To: dim, imp, bapt, rodrigc
Cc: imp, freebsd-toolchain


More information about the freebsd-toolchain mailing list