[RFC] [Optionally] build tests with buildworld
yaneurabeya at gmail.com
Wed Apr 24 16:15:33 UTC 2013
On Apr 23, 2013, at 10:28 AM, Garrett Cooper wrote:
> On Apr 23, 2013, at 9:59 AM, Brooks Davis wrote:
>> On Fri, Apr 19, 2013 at 11:17:50PM -0700, Garrett Cooper wrote:
>>> Hi arch@ and toolchain@,
>>> One of the items that I'm proposing be added to Makefile.inc1 in
>>> order to make building and installing tests on CURRENT (ATF and
>>> otherwise) is a build knob called TESTS_WITH_WORLD (the name can be
>>> modified), which allows me to build and install various tests on my
>>> git branch like the example ATF tests I produced, pjdfstest, some of
>>> the prove tests from tools/regression, etc (there are other
>>> outstanding changes, but this was the key one that I need feedback on
>>> just to be safe).
>> I don't understand way you don't use WITH_TESTS processed
>> through bsd.own.mk. You'd presumably have to add it to the list of
>> supported NO_* options for the bootstrap case, but that's trivial. Then
>> you use could use normal MK_* variables. That would also let you use
>> WITH(OUT)_TESTS in individual directories and they would always work.
>> At a glance using WITHOUT_TESTS and NO_TEST internally would simplify
>> some of the special cases in your patch.
> This is something that I considered, but I wasn't sure that it was the best route to go about things because I thought we were doing away/had done away with most of the NO_* knobs (and unfortunately one cannot mix and match WITH_* and WITHOUT_* because they're considered contradictory according to bsd.own.mk -- something that Simon has debated against having in the past).
> I'm all for doing that though because that would simplify things greatly from an end-user perspective.
Does this look ok? Most of the MK_TESTS logic has been shoved into bsd.own.mk and NO_TESTS is sprinkled around Makefile.inc1 as recommended.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 2678 bytes
Desc: not available
More information about the freebsd-toolchain