[PATCH] Add missing pthread_condattr_{init, destroy} stubs to libc

Kostik Belousov kostikbel at gmail.com
Fri Nov 27 22:30:58 UTC 2009

On Fri, Nov 27, 2009 at 05:28:07PM -0500, Joe Marcus Clarke wrote:
> On Sat, 2009-11-28 at 00:22 +0200, Kostik Belousov wrote:
> > On Fri, Nov 27, 2009 at 05:11:13PM -0500, Joe Marcus Clarke wrote:
> > > I didn't see a better way of fixing this.  I'm still fuzzy on how to do
> > > the correct symbol map dance for libthr/libc_r.  Do you know of any
> > > example symbols which had to be updated in this fashion?
> > 
> > pthread_condattr_init and _destroy are exported from libthr in FBSD_1.0.
> > namespace. I think stubs should go into FBSD_1.0 namespace in libc then.
> > 
> > We nullified one of the use for symver by extending existing
> > namespaces (symbol versioning, as defined by Sun, allowed for dynamic
> > linker to make a guarantee that process does not have unresolved
> > symbols only by checking that all required versions are provided
> > by libraries). My opinion that adding them to FBSD_1.0 is ok.
> That's easy enough.  New patch is up.
> http://www.marcuscom.com/downloads/stubs.diff

I think symbols should be added in the pthread_* block of the
libc/gen/Symbol.map, arranged alphabetically.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-threads/attachments/20091127/5ff5a481/attachment.pgp

More information about the freebsd-threads mailing list