threads/76938: include/unistd.h: ttyname_r prototype missing

Daniel Eischen deischen at freebsd.org
Fri Feb 18 12:51:11 PST 2005


On Fri, 18 Feb 2005, Craig Rodrigues wrote:

> The following reply was made to PR threads/76938; it has been noted by GNATS.
>
> From: Craig Rodrigues <rodrigc at crodrigues.org>
> To: freebsd-gnats-submit at freebsd.org
> Cc: tmclaugh at sdf.lonestar.org, freebsd-standards at freebsd.org
> Subject: Re: threads/76938: include/unistd.h: ttyname_r prototype missing
> Date: Fri, 18 Feb 2005 15:30:45 -0500
>
>  The following patch exports ttyname_r() from <unistd.h> and makes it
>  conform to the Single Unix Specification:
>  http://www.opengroup.org/onlinepubs/009695399/functions/ttyname.html
>
>  Can someone with a commit bit take a look at it?

Style: all returns should be "return (foo)", not "return foo".

This may also cause an ABI change since ttyname_r use to
return (char *).  I'm not sure of the impact though 'cause
it was never in a header file.

-- 
DE



More information about the freebsd-threads mailing list