kern_threads.c.. upcall question..

Julian Elischer julian at elischer.org
Wed May 7 13:08:53 PDT 2003



On Tue, 6 May 2003, Daniel Eischen wrote:

> On Tue, 6 May 2003, Julian Elischer wrote:
> > 
> > On Tue, 6 May 2003, David Xu wrote:
> > 
> > > 
> > > > I think this could be optimised even more.
> > > > (why copy the FP regs if they are not valid) (etc).
> > > > but it is an improvement..
> > > > 
> > > 
> > > Why need we an intermediate mcontext_t, why not
> > > direct copy the context in trap frame to userland space?
> > > This should be fastest. :-)
> > 
> > this is what I was thinking..
> > get_mcontext_user(td, addr)
> > [...]
> 
> Don't break validation and setting of FP validity and type.
> get_mcontext() knows how to mark the validity of the FPU
> set and it's type (387 or SSE).  The UTS relies on this
> information.  Be very careful.

Can you test david's simple patch that just removes the copy-in?
We can wate til later to do the optimisations..

> 
> -- 
> Dan Eischen
> 
> 



More information about the freebsd-threads mailing list