atf-sh shebang

[Kristof Provost]

On 8 Apr 2021, at 15:58, Olivier Cochard-Labbé wrote:
> atf-sh(1) man page says:
> "
> Scripts using atf-sh(3) should start with:
>            #! /usr/bin/env atf-sh
> "
>
> And env(1) man page says: "The env utility uses the PATH environment
> variable to locate the requested utility"
>
> But atf-sh is installed in /usr/libexec/ and this directory is not in 
> the
> default PATH.
>
> So should we:
> 1. update the atf-sh(1) man page;

That’s probably the best option, given that our makefiles generate 
this for test scripts:

	#! /usr/libexec/atf-sh

The source files for test scripts (e.g. 
/usr/src/tests/sys/netpfil/pf/pfsync.sh) do not include the shebang. 
It’s inserted by the build system.

> 2. or update the default $PATH to add /usr/libexec;
> 3. or moving atf-sh into a directory referenced by the default $PATH ?
>

Best regards,
Kristof