[Bug 220307] libxo tests are failing after recent update

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220307

--- Comment #3 from Ngie Cooper <ngie at FreeBSD.org> ---
(In reply to Phil Shafer from comment #2)

This bug still has issues that need to be resolved. I applied this patch for
starters, which fixed a number of items:

====================================================================================

$ svn diff usr.bin/xo
Index: usr.bin/xo/tests/functional_test.sh
===================================================================
--- usr.bin/xo/tests/functional_test.sh (revision 320663)
+++ usr.bin/xo/tests/functional_test.sh (working copy)
@@ -42,8 +42,8 @@

        atf_check -s exit:0 -e file:${err_file} -o file:${out_file} \
            env LC_ALL=en_US.UTF-8 \
-               LIBXO_OPTIONS=":W${xo_fmt}" TZ="EST" "${SRCDIR}/${tc}" \
-               ${XO}
+               TZ="EST" "${SRCDIR}/${tc}" \
+               "${XO} -W${xo_fmt}"
 }

 add_testcase()

After that, I ran into these issues:

$ (cd usr.bin/xo/tests/; make; sudo make install; make check)
install  -o root  -g wheel -m 555  xo_01  /usr/tests/usr.bin/xo/xo_01
install  -o root  -g wheel -m 555  functional_test 
/usr/tests/usr.bin/xo/functional_test
install  -o root  -g wheel -m 444  Kyuafile  /usr/tests/usr.bin/xo/Kyuafile
install  -o root -g wheel  -m 444
/usr/src/contrib/libxo/tests/xo/saved/xo_01.H.err
/usr/src/contrib/libxo/tests/xo/saved/xo_01.H.out
/usr/src/contrib/libxo/tests/xo/saved/xo_01.HIPx.err
/usr/src/contrib/libxo/tests/xo/saved/xo_01.HIPx.out
/usr/src/contrib/libxo/tests/xo/saved/xo_01.HP.err
/usr/src/contrib/libxo/tests/xo/saved/xo_01.HP.out
/usr/src/contrib/libxo/tests/xo/saved/xo_01.J.err
/usr/src/contrib/libxo/tests/xo/saved/xo_01.J.out
/usr/src/contrib/libxo/tests/xo/saved/xo_01.JP.err
/usr/src/contrib/libxo/tests/xo/saved/xo_01.JP.out
/usr/src/contrib/libxo/tests/xo/saved/xo_01.T.err
/usr/src/contrib/libxo/tests/xo/saved/xo_01.T.out
/usr/src/contrib/libxo/tests/xo/saved/xo_01.X.err
/usr/src/contrib/libxo/tests/xo/saved/xo_01.X.out
/usr/src/contrib/libxo/tests/xo/saved/xo_01.XP.err
/usr/src/contrib/libxo/tests/xo/saved/xo_01.XP.out /usr/tests/usr.bin/xo/
functional_test:xo_01__H  ->  passed  [0.029s]
functional_test:xo_01__HIPx  ->  failed: atf-check failed; see the output of
the test for details  [0.039s]
functional_test:xo_01__HP  ->  failed: atf-check failed; see the output of the
test for details  [0.040s]
functional_test:xo_01__J  ->  passed  [0.030s]
functional_test:xo_01__JP  ->  failed: atf-check failed; see the output of the
test for details  [0.037s]
functional_test:xo_01__T  ->  passed  [0.029s]
functional_test:xo_01__X  ->  passed  [0.030s]
functional_test:xo_01__XP  ->  failed: atf-check failed; see the output of the
test for details  [0.038s]

Results file id is usr_tests_usr.bin_xo.20170705-193650-601725
Results saved to
/home/ngie/.kyua/store/results.usr_tests_usr.bin_xo.20170705-193650-601725.db

4/8 passed (4 failed)
*** Error code 1

Stop.
make: stopped in /usr/src/usr.bin/xo/tests

====================================================================================

It seems that -I and -P are no longer supported, which matches what's noted in
xo(1).

-- 
You are receiving this mail because:
You are on the CC list for the bug.