[Bug 201286] tools/regression/security/open_to_operation/open_to_operation.c:172: bad if test ?

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Fri Oct 30 10:09:46 UTC 2015


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=201286

--- Comment #2 from commit-hook at freebsd.org ---
A commit references this bug:

Author: ngie
Date: Fri Oct 30 10:09:04 UTC 2015
New revision: 290190
URL: https://svnweb.freebsd.org/changeset/base/290190

Log:
  Fix compiler warnings with open_to_operation.c

  Other sidenotes:
  - Remove unused variables with main(..)
  - Convert errx/exit with -1 to errx/exit with 1
  - Fix a bogus test in try_directory_open
    (expected_errno == expected_errno -> errno == expected_errno) [*]
  - Fix some warnings related to discarded qualifiers
  - Remove a bogus else-statement at the end of check_mmap_exec(..) in the
    successful case. mmap(2), POSIX, Linux, etc all don't state what the
    behavior is when mixing O_WRONLY + PROT_EXEC, so assume success for now to
    get the test program to pass again.

  PR: 201286 [*]
  MFC after: 1 week
  Submitted by: David Binderman <dcb314 at hotmail.com>
  Sponsored by: EMC / Isilon Storage Division

Changes:
  head/tools/regression/security/open_to_operation/Makefile
  head/tools/regression/security/open_to_operation/open_to_operation.c

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-testing mailing list