Introducing the ZFS test suite

Alan Somers asomers at
Mon Sep 8 14:59:48 UTC 2014

On Mon, Sep 8, 2014 at 8:23 AM, Julio Merino <jmmv at> wrote:
> On Mon, Aug 25, 2014 at 2:38 PM,  <asomers at> wrote:
>> I just merged the ZFS test suite to projects/zfsd/head in change 270604.
>> [...]
>> The ZFS test suite still has some problems.  Some of these are
>> blocking it from being merged to head:
>> * The atf-ksh93 hack.  This is not a good thing to officially add to
>> ATF, but it would be a lot of work to convert the test programs to run
>> under sh.  Especially because of the use of ksh arrays.
> As we discussed, agreed that this is a bit hackish, but I think this
> is a reasonable compromise and the hack is unlikely to break anytime
> soon.  (Haven't looked at the specifics that were implemented though.)
>  Therefore, I would personally not consider a "rewrite in sh" to be a
> blocker for merging into head.

Good.  That certainly reduces the workload.

>  > Remember, don't run these tests on a production system.
> What's the plan for this?
> Are the tests somehow disabled by default so that a user running the
> full test suite is not tripped by this?

Currently, most if not all of the tests reference the
test_suites.FreeBSD.disks variable.  We should add it to
require.configs, and then none of them will run by default.  The
bigger problem, though, is that even if you define that variable, many
disks will destroy all pools on cleanup unless you also define the
keep_pools variable.  It's part of the default_cleanup_noexit function
in libtests.kshlib.  That must be fixed.

> Or will all the panics and deadlocks be fixed before merging to head?

I doubt it.  I certainly don't want to wait for it.  But merging these
tests to head will certainly help to focus attention on those bugs.

> Thanks for doing this!

More information about the freebsd-testing mailing list