[PATCH v2] convert /bin/sh tests over to ATF

Julio Merino jmmv at freebsd.org
Sun Mar 9 20:42:59 UTC 2014

On Mon, Mar 3, 2014 at 1:40 PM, Garrett Cooper <yaneurabeya at gmail.com> wrote:
> On Sun, Mar 2, 2014 at 1:14 PM, Julio Merino <jmmv at freebsd.org> wrote:
>> * The FILES must continue to be installed. Does this actually work
>> when running your test programs after a "make install"?
> Could you please clarify your concern here? I'm not sure I understood
> what you meant.

The tests need to populate /usr/tests/bin/sh/ with the
functional_test.sh driver and all its supporting data files. As I
understand it, your driver code assumes that the data files are
external (i.e. not bundled into the script itself), so those files
must be available from the same location as where the driver lives.
Hence you still need to use FILES to ensure the data files get
installed into /usr/tests/.

... but maybe I'm missing something from your patch; haven't reviewed
it again to double-check this.

More information about the freebsd-testing mailing list