[PATCH v2] convert bin/date over to ATF
yaneurabeya at gmail.com
Mon Mar 3 18:31:36 UTC 2014
On Sun, Mar 2, 2014 at 1:22 PM, Julio Merino <jmmv at freebsd.org> wrote:
> On Mon, Jan 27, 2014 at 5:03 AM, Garrett Cooper <yaneurabeya at gmail.com> wrote:
>> The attached patch incorporates the input from Julio for converting bin/date/tests over to ATF.
> Apologies for the delay here as well...
> Pretty much all style nits:
> * This file is full of boilerplate and it's really hard to actually
> see the tests. I think this would benefit from a simple helper
> function that calls atf_test_case and evals the tiny body() with the
> call to check.
> * I'd get rid of the descr definitions; they provide no value.
> * I'd also get rid of all the horizontal dividing lines. If you make
> the test case definitions compact, they just serve to increase the
> file length.
> * Remove the TZ and LC_ALL overrides. This is a given within ATF.
> * Why "format_string_functional_test"? I'd just call it "format_string_test".
I guess I could...
> * I don't think the # vim trailing line belongs in the tree.
More information about the freebsd-testing