[PATCH] Integrate pjdfstest into the build

[Garrett Cooper]

On Mar 2, 2014, at 1:31 PM, Julio Merino <jmmv at freebsd.org> wrote:

> On Mon, Jan 27, 2014 at 5:41 AM, Garrett Cooper <yanegomi at gmail.com> wrote:
>> Hi all,
>>        The attached patch integrates pjdfstest into the build. It also simplifies some logic in tests/sys/Makefile when copying Kyuafile.
> 
> Aaand one more time, apologies for the delay.  I think I'm caught up now!
> 
> * What's the point of PJDFSTEST_I_KNOW_WHAT_I_AM_DOING?  *Why* is it a
> very bad idea to do so?

It’s a safety belt.

I’ve run into cases where interrupted test runs fill up filesystems with data (either free space or inodes). Depending on what method you use to clean up the contents of directories, it can take ages to delete all of the files (rm -rf for instance is a very linear operation, but parallel rm -rf’s are considerably quicker). I’ll add a comment to this effect.

> * The 'tests' path component in pjdfstest/tests/ should go away; it is
> redundant.

It’s not redundant; it’s needed for the conf file:

# make all
===> pjdfstest (all)
===> tests (all)
make[1]: don't know how to make conf. Stop

make[1]: stopped in /usr/src/tests/sys/pjdfstest/tests
*** Error code 2

Stop.
make: stopped in /usr/src/tests/sys/pjdfstest
# git checkout -- tests/Makefile 
…
# echo $?
0

> * Add $FreeBSD$ tags everywhere where missing.

I’ll add those.

> * The test files should move from tools/regression/pjdfstest/ into the
> new location under tests/sys/ and be renamed to follow the conventions
> under src/test (e.g. xx.t -> xx_test).

Please talk to Pawel about this. These tests have been developed and are maintained (to some degree) outside FreeBSD: https://github.com/pjd/pjdfstest . I’d rather treat this as an integration of the 3rd party package, not a refactor. If you want me to install the tests like _test though, I’d be more than happy to do that.

Thank you :)!
-Garrett