[PATCH v2] convert /bin/sh tests over to ATF

Garrett Cooper yaneurabeya at gmail.com
Fri Jun 13 00:53:48 UTC 2014

On Sun, May 11, 2014 at 8:32 AM, Jilles Tjoelker <jilles at stack.nl> wrote:


> This is OK with me as long as important use cases for me are not broken:
> 1. Allow running new tests on a potentially broken new sh without
>    installing anything. This used to be possible using 'make regress' in
>    src/bin/sh/ but this was removed. I now use
>      SH=$PWD/obj/sh sh tests/legacy_test.sh
>    (I have an obj/ subdirectory to make the built objects more easily
>    accessible).
>    This should also work on stable/9 although it is acceptable to need a
>    few local hacks for that (as is already the case for MK_TESTS and
>    src.opts.mk). On head, it should work without local hacks.

I allow you to change the shell via TEST_SH -- is that acceptable for
the first drop (I'll look at revising the code to permit runtime
overrides via kyua)?

> 2. Allow installing using a read-only /usr/obj (mounted over NFS). This
>    means that everything needs to be built during buildworld.
>    Installworld should not build anything.
>    (I currently have local hacks: Kyuafile.auto is not built so I added
>      all: Kyuafile.auto
>    to some tests/Makefiles; I guess this should be in <bsd.test.mk>.)

That's another issue entirely that you brought up in another thread.
I'll see if that's still an issue..

Thank you!

More information about the freebsd-testing mailing list