[PATCH] convert /bin/sh tests over to ATF

[Garrett Cooper]

On Jan 24, 2014, at 8:27 AM, Jilles Tjoelker <jilles at stack.nl> wrote:

> On Mon, Jan 20, 2014 at 08:44:58AM -0800, Garrett Cooper wrote:
>> Also, I added some functionality so the tests expect failures on
>> certain versions of FreeBSD due to missing functionality or
>> conformance modifications (see the .valid_osreldate files).
> 
> I think this part is a bit too simplistic and inflexible. I have always
> dealt with changes affecting the tests by MFCing the changes to the
> tests along with the changes to sh itself, and this has worked well
> enough. On the other hand, I also run -current's sh and tests on my
> -stable machine, without installing the tests (and often also without
> installing the new sh). Therefore, the osreldate of the machine does not
> imply that the sh is also of that version.
> 
> There are also changes like r222684 that need an adjustment to the tests
> which are hard to handle properly using a .valid_osreldate file.

Fair enough. Long story short, when I wrote this I was still working at EMC on a FreeBSD port project where we were porting revision-by-revision, so in order for the tests to not fail [so much], it helped to write in these checks. I agree though, this shouldn’t hit mainline FreeBSD at all (will yank it).

> There may be some point in marking tests that are supposed to work on
> any POSIX-compliant sh and ones that are inherently FreeBSD-specific, or
> possibly more granular. However, this would be most useful when someone
> who cares about another sh implementation works on it.

Ok.

Thanks!
-Garrett