[PATCH] convert bin/date over to ATF

[Julio Merino]

On Thu, Jan 23, 2014 at 5:16 PM, Garrett Cooper <yaneurabeya at gmail.com> wrote:
> On Jan 22, 2014, at 3:56 PM, Julio Merino <julio at meroh.net> wrote:
>
>> On Jan 20, 2014, at 13:40, Garrett Cooper <yaneurabeya at gmail.com> wrote:
>>
>>>      This is based on work done by Giorgos a couple years ago.
>>> Thanks!
>>> -Garrett
>>
>> Pasting patch contents and commenting inline:
>>
>>> diff --git a/bin/date/tests/Makefile b/bin/date/tests/Makefile
>>> index 540008b..459d019 100644
>>> --- a/bin/date/tests/Makefile
>>> +++ b/bin/date/tests/Makefile
>>> @@ -4,6 +4,6 @@
>>>
>>> TESTSDIR=    ${TESTSBASE}/bin/date
>>>
>>> -TAP_TESTS_SH=       legacy_test
>>> +ATF_TESTS_SH=       regress
>>
>> Tests ought to end with _test per the description in https://wiki.freebsd.org/TestSuite/Structure
>
> Ok! Is `_tests` ok?

_test is a very common convention "out there"; I've seen it used
pretty much everywhere plus we already have a bunch of _test programs.
 I don't think diverging to _tests is a good idea.

(The rationale for _test, I believe, is that this refers to the "test
program", not its contents. But who knows -- I'm just making that up.)

>> Also, "regress_test" is not a very indicative name.  Will this only contain test cases for bugs to prevent regressions?
>
> It should be “date_functional_tests”, because that’s what they’re doing.

Sure; the more descriptive, the better. (But note that this will live
in a "date" subdirectory, so arguably functional_test is enough.)

-- 
Julio Merino / @jmmv