Makefile.inc1.patch

[Alan Somers]

On Tue, Jan 21, 2014 at 3:17 PM, Garrett Cooper <yaneurabeya at gmail.com> wrote:
> Hi all,
>     The attached patch fixes/enhances the build so -DNO_TESTS is passed properly through various sections of the build that don't require tests in order to build/install. This should also fix Alan's recent reported issue with -DWITH_TESTS failing on amd64.
> Cheers!
> -Garrett
>

The patch doesn't work for me.  I get the following error during
buildworld during stage 4.4.


--- atf-check ---
--- games.all__D ---
===> games/morse (all)
--- libexec.all__D ---
c++  -O2 -pipe -DHAVE_CONFIG_H
-I/usr/home/alans/freebsd/head/contrib/atf -Qunused-arguments
-fstack-protector -Wsystem-headers -Werror -Wall -Wno-format-y2k -W
-Wno-unused-parameter -Wpointer-arith -Wno-uninitialized
-Wno-empty-body -Wno-string-plus-int -Wno-tautological-compare
-Wno-unused-value -Wno-parentheses-equality -Wno-unused-function
-Wno-enum-conversion -Wno-c++11-extensions
-L/vmpool/obj/usr/home/alans/freebsd/head/libexec/atf/atf-check/../../../lib/atf/libatf-c++
-L/vmpool/obj/usr/home/alans/freebsd/head/libexec/atf/atf-check/../../../lib/atf/libatf-c
-o atf-check atf-check.o -latf-c++ -latf-c
--- lib.all__D ---
--- unmount.po ---
cc  -DPROF -O2 -pipe  -I/usr/home/alans/freebsd/head/lib/libc/include
-I/usr/home/alans/freebsd/head/lib/libc/../../include
-I/usr/home/alans/freebsd/head/lib/libc/amd64 -DNLS
-D__DBINTERFACE_PRIVATE
-I/usr/home/alans/freebsd/head/lib/libc/../../contrib/gdtoa
-I/usr/home/alans/freebsd/head/lib/libc/../../contrib/libc-vis -DINET6
-I/vmpool/obj/usr/home/alans/freebsd/head/lib/libc
-I/usr/home/alans/freebsd/head/lib/libc/resolv -D_ACL_PRIVATE
-DPOSIX_MISTAKE
-I/usr/home/alans/freebsd/head/lib/libc/../../contrib/jemalloc/include
-I/usr/home/alans/freebsd/head/lib/libc/../../contrib/tzcode/stdtime
-I/usr/home/alans/freebsd/head/lib/libc/stdtime
-I/usr/home/alans/freebsd/head/lib/libc/locale -DBROKEN_DES -DPORTMAP
-DDES_BUILTIN -I/usr/home/alans/freebsd/head/lib/libc/rpc -DYP
-DNS_CACHING -DSYMBOL_VERSIONING -std=gnu99 -Qunused-arguments
-fstack-protector -Wsystem-headers -Werror -Wall -Wno-format-y2k
-Wno-uninitialized -Wno-pointer-sign -Wno-empty-body
-Wno-string-plus-int -Wno-tautological-compare -Wno-unused-value
-Wno-parentheses-equality -Wno-unused-function -Wno-enum-conversion
-Wno-switch -Wno-switch-enum -Wno-knr-promoted-parameter  -c unmount.S
-o unmount.po
--- gnu.all__D ---
--- checklist.po ---
cc  -pg  -O2 -pipe  -I/usr/home/alans/freebsd/head/gnu/lib/libdialog
-I/usr/home/alans/freebsd/head/gnu/lib/libdialog/../../../contrib/dialog
-D_XOPEN_SOURCE_EXTENDED -DGCC_UNUSED=__unused -std=gnu99
-Qunused-arguments  -fstack-protector -Wsystem-headers -Werror
-Wno-pointer-sign -Wno-empty-body -Wno-string-plus-int
-Wno-tautological-compare -Wno-unused-value -Wno-parentheses-equality
-Wno-unused-function -Wno-enum-conversion -Wno-switch -Wno-switch-enum
-Wno-knr-promoted-parameter -Wno-parentheses -c
/usr/home/alans/freebsd/head/gnu/lib/libdialog/../../../contrib/dialog/checklist.c
-o checklist.po
--- libexec.all__D ---
/vmpool/obj/usr/home/alans/freebsd/head/tmp/usr/bin/ld: cannot find -latf-c++
c++: error: linker command failed with exit code 1 (use -v to see invocation)
*** [atf-check] Error code 1