My first ATF test

Alan Somers asomers at
Tue Feb 25 16:47:55 UTC 2014

On Tue, Feb 25, 2014 at 9:11 AM, Peter Holm <peter at> wrote:
> In order to understand how ATF works I wrote a small test so I had
> something to work with:
> Did I get it right?

ATF-wise, it looks good.  However, it's a bad idea to use random
numbers in test code, except in stress tests.  Random numbers result
in irreproducible tests.  How about replacing the body of dup2_r234131
with something like this?

  int fd1, fd2, ret;
  fd1 =  open("/etc/passwd", O_RDONLY);
  fd2 = INT_MAX;
  ret = dup2(fd1, fd2);
  ATF_CHECK_EQ(-1, ret);

On a side note, perhaps WARNS should be set in, so we
won't have to set it in every other Makefile.


More information about the freebsd-testing mailing list