Refactoring of *.test.mk

Simon J. Gerraty sjg at juniper.net
Tue Oct 15 06:23:01 UTC 2013


Thanks Julio,

looks good.

One nit; in hook-atf-run.diff and hook-kyua.diff I see:

+TESTS_ENV+= ATF_BUILD_CC=${DESTDIR}/usr/bin/cc

etc.  
It would be safer to allow ATF_BUILD_CC etc to be controlled 
eg.

TESTS_ENV+= ATF_BUILD_CC=${ATF_BUILD_CC:U${DESTDIR}/usr/bin/cc}
..

or
ATF_BUILD_CC?= ${DESTDIR}/usr/bin/cc
..
TESTS_ENV+= ATF_BUILD_CC=${ATF_BUILD_CC}
..


On Mon, 14 Oct 2013 23:24:39 -0400, Julio Merino writes:
>[Fixing Garrett's address...]



More information about the freebsd-testing mailing list