[Bug 247102] getlogin_r(): Sort of a typo: int is actually a size_t
bugzilla-noreply at freebsd.org
bugzilla-noreply at freebsd.org
Wed Sep 9 18:07:28 UTC 2020
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=247102
--- Comment #10 from commit-hook at FreeBSD.org ---
A commit references this bug:
Author: kevans
Date: Wed Sep 9 18:07:14 UTC 2020
New revision: 365506
URL: https://svnweb.freebsd.org/changeset/base/365506
Log:
getlogin_r: fix the type of len
getlogin_r is specified by POSIX to to take a size_t len, not int. Fix our
version to do the same, bump the symbol version due to ABI change and
provide compat.
This was reported to break compilation of Ruby 2.8.
Some discussion about the necessity of the ABI compat did take place in the
review. While many 64-bit platforms would likely be passing it in a 64-bit
register and zero-extended and thus, not notice ABI breakage, some do
sign-extend (e.g. mips).
PR: 247102
Submitted by: Bertram Scharpf <software at bertram-scharpf.de> (original)
Submitted by: cem (ABI compat)
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D26335
Changes:
head/include/unistd.h
head/lib/libc/gen/Symbol.map
head/lib/libc/gen/getlogin.c
head/lib/libc/sys/getlogin.2
--
You are receiving this mail because:
You are the assignee for the bug.
More information about the freebsd-standards
mailing list