standards/170346: Changes to support waitid() and related stuff

[Konstantin Belousov]

On Sat, Oct 13, 2012 at 10:50:01AM +0000, Jukka A. Ukkonen wrote:
> The following reply was made to PR standards/170346; it has been noted by GNATS.
> 
> From: "Jukka A. Ukkonen" <jau at oxit.fi>
> To: bug-followup at FreeBSD.org, jau at iki.fi
> Cc:  
> Subject: Re: standards/170346: Changes to support waitid() and related stuff
> Date: Sat, 13 Oct 2012 13:38:27 +0300
> 
>  This is a multi-part message in MIME format.
>  --------------080903030501070905090806
>  Content-Type: text/plain; charset=ISO-8859-1; format=flowed
>  Content-Transfer-Encoding: 7bit
>  
>  
>  Right, having said that I would stop modifying this I have to
>  break that promise.
>  I had forgotten one change which I had intended to make.
>  Previously the siginfo structure was zeroed inside the kernel
>  when wait6() returned 0. This has now been moved out of
>  the kernel and put inside waitid().
>  Now this should be stable. I have no more planned changes
>  waiting to be included.
>  
>  As before start with 9.1-RC2 (9-stable), apply the patch, run
>  
>  ( cd /usr/src/sys/kern ; make sysent )
>  ( cd /usr/src/sys/compat/freebsd32 ; make sysent )
>  
>  and build the whole system.

I reviewed the patch and besides fixing enormous style violations, I also
made the following changes:
- The man page was mostly converted from the description of what is different
  with waitid(2) to just describing waitid interface as yet another function.
- The fix for the kernel stack content leakage from wait6. Basically, the
  kernel must clear the structure as the first step.
- Portability fixes: Linux returns signal number in si_status.
- Fixes for exported symbol list and their location.
See the patch at
http://people.freebsd.org/~kib/misc/waitid.1.patch

Otherwise, it looks good and is almost ready to commit, e.g. it passes
glibc waitid test.

To be able to commit, I need a copyright text to be filled into
libc/gen/waitid.c, look for XXX there. Or, at least, please specify that
you agree to license the code under the 3 (or 2) clause bsd license.

Thank you.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-standards/attachments/20121029/5cf0a487/attachment.sig>