standards/79788: natd "reverse" option makes segmentation fault

[Maxim Konovalov]

The following reply was made to PR standards/79788; it has been noted by GNATS.

From: Maxim Konovalov <maxim at macomnet.ru>
To: Sergey Vavilov <sergey at vavilov.org>
Cc: bug-followup at freebsd.org
Subject: Re: standards/79788: natd "reverse" option makes segmentation fault
Date: Mon, 11 Apr 2005 15:39:32 +0400 (MSD)

 > >Number:         79788
 > >Category:       standards
 
 Why "standards"?
 
 > >Synopsis:       natd "reverse" option makes segmentation fault
 [...]
 > >Release:        5.3
 [...]
 > >Description:
 > I use natd on machine with 1 NIC.
 > Problem - segmentatin fault within "reverse" option enabled
 > >How-To-Repeat:
 > include option "reverse" into natd's config file
 
 I believe phk has fixed this issue in rev. 1.50 libalias/alias.c,
 bin/76839 and MFC'ed changes to RELENG_5.  Could you please upgrade
 your system to RELENG_5 or RELENG_5_4 or try an enclosed patch?
 
 Index: alias.c
 ===================================================================
 RCS file: /home/ncvs/src/lib/libalias/alias.c,v
 retrieving revision 1.49
 retrieving revision 1.50
 diff -u -r1.49 -r1.50
 --- alias.c	14 Aug 2004 14:21:09 -0000	1.49
 +++ alias.c	5 Apr 2005 13:04:35 -0000	1.50
 @@ -1170,7 +1170,7 @@
 
  	if (la->packetAliasMode & PKT_ALIAS_REVERSE) {
  		la->packetAliasMode &= ~PKT_ALIAS_REVERSE;
 -		iresult = PacketAliasOut(ptr, maxpacketsize);
 +		iresult = LibAliasOut(la, ptr, maxpacketsize);
  		la->packetAliasMode |= PKT_ALIAS_REVERSE;
  		return (iresult);
  	}
 @@ -1264,7 +1264,7 @@
 
  	if (la->packetAliasMode & PKT_ALIAS_REVERSE) {
  		la->packetAliasMode &= ~PKT_ALIAS_REVERSE;
 -		iresult = PacketAliasIn(ptr, maxpacketsize);
 +		iresult = LibAliasIn(la, ptr, maxpacketsize);
  		la->packetAliasMode |= PKT_ALIAS_REVERSE;
  		return (iresult);
  	}
 %%%
 
 -- 
 Maxim Konovalov