standards/52972: /bin/sh arithmetic not POSIX compliant
schweikh at schweikhardt.net
Thu Jul 3 12:50:18 PDT 2003
The following reply was made to PR standards/52972; it has been noted by GNATS.
From: Jens Schweikhardt <schweikh at schweikhardt.net>
To: Wartan Hachaturow <wart at tepkom.ru>
Cc: GNATS Bug Followup <bug-followup at FreeBSD.org>
Subject: Re: standards/52972: /bin/sh arithmetic not POSIX compliant
Date: Thu, 3 Jul 2003 21:40:06 +0200
On Thu, Jul 03, 2003 at 06:27:53PM +0400, Wartan Hachaturow wrote:
# I've hacked out a simple patch for 5.1-RELEASE's /bin/sh, implementing
# variables support in arithmetic evaluation, along with various assignment
# Since the patch is pretty big (11k), I won't include it right in the letter,
# it may be grabbed from
Thanks for taking up the grunt work and implementing this. This is more
than I hoped for!
I've looked at your patch (not yet applied and tested) and have a few
+ It appears this is a patch against RELENG_4; is this true? If yes, a
patch against HEAD is needed.
+ There are many lines with whitespace at end-of-line which you should
remove. Can you instruct your editor to make these visible?
+ Reversing comparisons against constant values like in
if (NULL == lookupvar($1))
look like a style(9) violation.
PS: 11k is not really a big patch. Nobody would mind if you send your
improved patch to the GNATS db. URLs with patches tend to become
stale very soon.
Jens Schweikhardt http://www.schweikhardt.net/
SIGSIG -- signature too long (core dumped)
More information about the freebsd-standards