net.inet.udp.log_in_vain strange syslog reports
Eric van Gyzen
vangyzen at FreeBSD.org
Mon Feb 6 17:04:48 UTC 2017
On 02/06/2017 10:19, Mark Martinec wrote:
>
> One minor nit:
> instead of a hack:
>
> char src[4*sizeof "123"];
> char dst[4*sizeof "123"];
>
> it would be cleaner and in sync with the equivalent code in
> sys/netinet6/udp6_usrreq.c
> to use the INET_ADDRSTRLEN constant (from sys/netinet/in.h, value 16):
>
> char src[INET_ADDRSTRLEN];
> char dst[INET_ADDRSTRLEN];
Agreed.
> Hope the fix finds its way into 11.1 (or better yet, as a patch level in
> 10.0).
> Should I open a bug report?
It will quite likely get into 11.1. As for a 10.x patch, you would have
to ask re@ (I think), but I doubt it. These messages are really just
informative and can't be used for any filtering, since the source
address could be spoofed.
Eric
More information about the freebsd-stable
mailing list